Skip to content

Commit

Permalink
Simplify DefaultSingletonBeanRegistry.isDependent()
Browse files Browse the repository at this point in the history
Move `alreadySeen` handling out of for-loop.

Closes gh-30841
  • Loading branch information
bnbakp0582 authored and sbrannen committed Jul 9, 2023
1 parent 0961bc5 commit 85eec5d
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -453,11 +453,11 @@ private boolean isDependent(String beanName, String dependentBeanName, @Nullable
if (dependentBeans.contains(dependentBeanName)) {
return true;
}
if (alreadySeen == null) {
alreadySeen = new HashSet<>();
}
alreadySeen.add(beanName);
for (String transitiveDependency : dependentBeans) {
if (alreadySeen == null) {
alreadySeen = new HashSet<>();
}
alreadySeen.add(beanName);
if (isDependent(transitiveDependency, dependentBeanName, alreadySeen)) {
return true;
}
Expand Down

0 comments on commit 85eec5d

Please sign in to comment.