Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Explicitly release rolled-back database savepoints during (long-runni…
…ng) transaction Issue: SPR-12228
- Loading branch information
Showing
2 changed files
with
22 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this fix is incorrect as it will introduces discrepancy between database notion of rollback to savepoint and
JdbcTransactionObjectSupport
(and its clients) view of rollback to savepoint. That is this fix does not allow replicate scenario absolutely valid in database:I believe the correct fix is like this romank0@e2b7b2a
The reason I didn't create PR for this is the bug in openjpa
rollbackToSavepoint
which is used for integration tests. The bug prevents this fix from working.