Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaAnnotationUtils should support arbitrary levels of meta-annotations [SPR-11470] #16095

Closed
1 task done
spring-projects-issues opened this issue Feb 22, 2014 · 2 comments
Closed
1 task done
Assignees
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Feb 22, 2014

Sam Brannen opened SPR-11470 and commented

Overview

The findAnnotationDescriptor() and findAnnotationDescriptorForTypes() methods in MetaAnnotationUtils currently only support a single level of meta-annotations.

In other words, meta-annotations on meta-annotations will never be found, and this does not align with Spring's standard support for meta-annotations with arbitrary levels.

Deliverables

  1. Alter the search algorithms used in MetaAnnotationUtils so that arbitrary levels of meta-annotations (e.g., meta-annotations on meta-annotations) are supported for test-related annotations.

Affects: 4.0 GA

Issue Links:

Referenced from: commits f895096

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 22, 2014

Sam Brannen commented

This issue is closely related to #16074 but specific to spring-test.

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

Completed as described in the comments for GitHub commit f895096:

Support arbitrary meta-annotation levels in the TCF

Prior to this commit, the findAnnotationDescriptor() and
findAnnotationDescriptorForTypes() methods in MetaAnnotationUtils only
supported a single level of meta-annotations. In particular, this kept
the following annotations from being used as meta-annotations on
meta-annotations:

  • @ContextConfiguration
  • @ContextHierarchy
  • @ActiveProfiles
  • @TestExecutionListeners

This commit alters the search algorithms used in MetaAnnotationUtils so
that arbitrary levels of meta-annotations are now supported for the
aforementioned test-related annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants