-
Notifications
You must be signed in to change notification settings - Fork 38k
-
Notifications
You must be signed in to change notification settings - Fork 38k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation misses chapters 4.13 and 4.14 [SPR-12107] #16723
Comments
Stéphane Nicoll commented This has been added and will be available in a couple of hours here |
Michael Osipov commented There seems to be some discrepancy between the reference and the Javadocs. The reference says:
but neither |
Stéphane Nicoll commented Thanks for reviewing.
I guess that's not obvious enough? I don't see myself explaining all that there as it's pretty specific and the javadoc is extensive (and there is a link). Suggestion? |
Michael Osipov commented I am sorry, this is not what I am was talking about. I was solely referring to profile activation. The according to the reference Maybe this is obvious to you by mentioning |
Stéphane Nicoll commented what Javadoc? If you're confused, something else must be wrong. I don't really get why you insist on focusing on Now that this abstraction is in place, you can resolve the Now you got this explanation, it would probably be easier if you explain what is missing in the curent doc. |
Michael Osipov commented Stéphane, I wasn't looking for an explanation but solely hinting that something is missing in the docs. You misunderstood me again. I was not referring to where properties are obtained from but solely how profiles can be activated. Reference says that I can enable profiles through JNDI but |
Stéphane Nicoll commented Michael I got you the first time I think and I will try one more time but if that's not good enough and you know what is missing, just write what's missing and that would help me get what you're after. I am taking the section in the doc you mentioned in your first comment. That section explains that there are two ways to enable a profile:
Now, how I can set the property? We give a wide range of options, including JNDI with a reference to the PropertySource abstraction. That section explains you can define properties ( Back to what is missing, Does that help? If not, please write down what you'd like to see. |
Michael Osipov commented Stéphane, yes I was referring to declarative enabling fo profiles. The paragraph
is simply too shallow for my taste. Most people will prefer context params or JNDI variables. That requires more attention. Especially that regardless of the source, it is always |
Michael Osipov opened SPR-12107 and commented
Both chapters refer to the blog for details. That is not how a documentation should be structured. Moreover, if the documenation is read offline or on paper, that information is simply not available.
Documenation should be selfcontained.
Affects: 4.1 RC2
Referenced from: commits 15f496b
The text was updated successfully, but these errors were encountered: