Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for conditional PUT in Web MVC (using If-Unmodified-Since header) [SPR-13863] #18436

Closed
spring-projects-issues opened this issue Jan 12, 2016 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 12, 2016

M. Justin opened SPR-13863 and commented

I have been converting a Jersey/JAX-RS application to Spring Web MVC, and discovered that while JAX-RS supports conditional PUT (using the "If-Unmodified-Since" header and the 412 "Precondition Failed" response) through Request.evaluatePreconditions, Spring Web MVC does not.

Looking through the spring-web codebase, the only reference to "If-Unmodified-Since" that I could find is in HttpEntityMethodProcessor. And that code only applies to GET requests. Additionally, there's WebRequest.checkNotModified (and seems to parallel the JAX-RS Request.evaluatePreconditions method), but only checks the "If-Modified-Since" header and also works only for GET and HEAD requests.

For my project I will be implementing conditional PUT manually. However, it feels like conditional PUT (and DELETE) requests should be baked into the Spring MVC framework.


Issue Links:

Referenced from: commits 0d6f800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants