Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractRequestLoggingFilter appends null query string [SPR-14244] #18817

spring-projects-issues opened this issue May 4, 2016 · 1 comment
in: web status: backported type: bug


Copy link

spring-projects-issues commented May 4, 2016

M. Justin opened SPR-14244 and commented

When using AbstractRequestLogingFilter to log requests with includeQueryString = true, "?null" is appended to requests that don't have a query string. I would expect no query string to be included in these cases.

public Filter logFilter() {
    CommonsRequestLoggingFilter filter = new CommonsRequestLoggingFilter();
    return filter;

Log output:

Before request [uri=/my/uri/path?null]

Expected log output:

Before request [uri=/my/uri/path]

Affects: 3.2.16, 4.2.5

Issue Links:

Backported to: 3.2.17

Copy link
Collaborator Author

spring-projects-issues commented May 4, 2016

Juergen Hoeller commented

Good catch! Fixed for 4.2.6 and 3.2.17 now.

@spring-projects-issues spring-projects-issues added type: bug status: backported in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.2.6 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
in: web status: backported type: bug
None yet

No branches or pull requests

2 participants