AbstractRequestLoggingFilter appends null query string [SPR-14244]

[spring-projects-issues]

M. Justin opened SPR-14244 and commented

When using AbstractRequestLogingFilter to log requests with includeQueryString = true, "?null" is appended to requests that don't have a query string. I would expect no query string to be included in these cases.

@Bean
public Filter logFilter() {
    CommonsRequestLoggingFilter filter = new CommonsRequestLoggingFilter();
    filter.setIncludeQueryString(true);
    return filter;
}

Log output:

Before request [uri=/my/uri/path?null]

Expected log output:

Before request [uri=/my/uri/path]

---

Affects: 3.2.16, 4.2.5

Issue Links:

• Add option to log headers to AbstractRequestLoggingFilter [SPR-14245] #18818 Add option to log headers to AbstractRequestLoggingFilter

Backported to: 3.2.17

[spring-projects-issues]

Juergen Hoeller commented

Good catch! Fixed for 4.2.6 and 3.2.17 now.