Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractRequestLoggingFilter appends null query string [SPR-14244] #18817

Closed
spring-issuemaster opened this issue May 4, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented May 4, 2016

M. Justin opened SPR-14244 and commented

When using AbstractRequestLogingFilter to log requests with includeQueryString = true, "?null" is appended to requests that don't have a query string. I would expect no query string to be included in these cases.

@Bean
public Filter logFilter() {
    CommonsRequestLoggingFilter filter = new CommonsRequestLoggingFilter();
    filter.setIncludeQueryString(true);
    return filter;
}

Log output:

Before request [uri=/my/uri/path?null]

Expected log output:

Before request [uri=/my/uri/path]

Affects: 3.2.16, 4.2.5

Issue Links:

  • #18818 Add option to log headers to AbstractRequestLoggingFilter

Backported to: 3.2.17

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 4, 2016

Juergen Hoeller commented

Good catch! Fixed for 4.2.6 and 3.2.17 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.