Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HttpComponentsAsyncClientHttpRequest abortable [SPR-14845] #19411

Closed
spring-projects-issues opened this issue Oct 25, 2016 · 3 comments
Closed

Make HttpComponentsAsyncClientHttpRequest abortable [SPR-14845] #19411

spring-projects-issues opened this issue Oct 25, 2016 · 3 comments
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
4.3.4

Comments

@spring-projects-issues
Copy link
Collaborator

Alessandro Ciccimarra opened SPR-14845 and commented

In HttpComponentsAsyncClientHttpRequest, the inner class HttpResponseFutureCallback has an empty cancelled() callback method. It should call httpRequest.abort() to be able to clean resources when we cancel the future, shouldn't it?
A possible simple implementation in the attached Gist.

Affects: 4.3.3

Reference URL: https://gist.github.com/alex859/59e5489b5e20eed03d456f8c41114786

Referenced from: commits b6b5366, 8f84446
@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Fixed in master: 8f84446

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Thanks for supplying a suggested fix!

@spring-projects-issues
Copy link
Collaborator Author

Alessandro Ciccimarra commented

No problems! Thank you!

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.3.4 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
4.3.4
Development

No branches or pull requests
2 participants
@poutsma @spring-projects-issues