Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make andRoute() a drop-in replacement for and(route()) [SPR-14904] #19470

Closed
spring-issuemaster opened this issue Nov 14, 2016 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

commented Nov 14, 2016

Sébastien Deleuze opened SPR-14904 and commented

Maybe I missed something, but this code compiles:

private static RouterFunction<?> routes() {
		return route(GET("docs/api/**"), request ->
				status(FOUND).header(LOCATION, request.path().replace("/docs/", "/old/")).build()
			).and(route(GET("docs/reference/**"), request ->
				status(FOUND).header(LOCATION, request.path().replace("/docs/", "/old/")).build()
			).and(route(GET("docs/raw/**"), request ->
				status(FOUND).header(LOCATION, request.path().replace("/docs/", "/old/")).build()
			).and(route(GET("core/docs/reference/**"), request ->
				status(FOUND).header(LOCATION, "https://github.com/reactor/reactor-core/blob/master/README.md").build()
			)
		)));
	}

While this one fails with this error message: bad return type in lambda expression: can't convert ServerResponse<Void> to ServerResponse<Object>.

private static RouterFunction<?> routes() {
		return route(GET("docs/api/**"), request ->
				status(FOUND).header(LOCATION, request.path().replace("/docs/", "/old/")).build()
			).andRoute(GET("docs/reference/**"), request ->
				status(FOUND).header(LOCATION, request.path().replace("/docs/", "/old/")).build()
			).andRoute(GET("docs/raw/**"), request ->
				status(FOUND).header(LOCATION, request.path().replace("/docs/", "/old/")).build()
			).andRoute(GET("core/docs/reference/**"), request ->
				status(FOUND).header(LOCATION, "https://github.com/reactor/reactor-core/blob/master/README.md").build()
			);
	}

Affects: 5.0 M3

Referenced from: commits 6de062d

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 14, 2016

Arjen Poutsma commented

Fixed in 6de062d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.