Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to enable streaming mode via annotations (and eventually app config) [SPR-15103] #19670

Closed
spring-projects-issues opened this issue Jan 6, 2017 · 4 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 6, 2017

Sébastien Deleuze opened SPR-15103 and commented

Like implemented on the functional framework via #19597, we should support a way to set hints potentially via a dedicated annotation (currently only the special case of @JsonView is supported). That could be used to customize the flushing strategy (#19547).


Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jan 31, 2017

Sébastien Deleuze commented

I suggest @Hint(key = "foo", value = ...) + using Java 8 repeating annotations (since multiple hints could be provided). That would be consistent with what we did on the functional API side (#19597). This should be supported at @RequestBody and @ResponseBody level.

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

With a @Hint annotation as described, users would not be able to set create hints dynamically in the method controller itself. Not sure if that is an issue, but worth noting.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 1, 2017

Sébastien Deleuze commented

Indeed, I tend to think that's a limitation we can live with but good point.

Another alternative to fulfill #19671 and #19547 is to provide more high level annotation or use existing annotation attibutes like @RequestBody or ResponseBody ones.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 12, 2017

Sébastien Deleuze commented

Resolving this as won't do because we decided to control streaming using media type, see #19671 and this commit for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants