Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resourceHandlerMapping should be registered with shared HandlerInterceptor [SPR-16034] #20583

Closed
spring-projects-issues opened this issue Oct 2, 2017 · 0 comments
Closed

resourceHandlerMapping should be registered with shared HandlerInterceptor [SPR-16034] #20583

spring-projects-issues opened this issue Oct 2, 2017 · 0 comments
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.0.1

Comments

@spring-projects-issues
Copy link
Collaborator

Brian Clozel opened SPR-16034 and commented

In WebMvcConfigurationSupport, the resource HandlerMapping is only registered with the ResourceUrlProviderExposingInterceptor and does not leverage the set of configured interceptors.

Even if ResourceUrlProviderExposingInterceptor might be enough for most use cases when serving static resources, registering additional interceptors can be useful for other use cases like metrics.

Reference URL: spring-projects/spring-boot#10335

Referenced from: commits 1356bd4
@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.1 milestone Jan 11, 2019
Closed
@wilkinsona wilkinsona mentioned this issue Feb 4, 2019
Closed
@bclozel bclozel mentioned this issue Nov 3, 2019
Closed
samarthrastogi pushed a commit to samarthrastogi/spring-framework that referenced this issue Nov 4, 2019
Update WebMvcConfigurer#addInterceptors javadoc
c088cbc 
spring-projectsgh-20583 updated resourceHandlerMapping to use shared interceptors.
addInterceptors in WebMvcConfigurer now adds interceptors for static
resources as well.
Closes spring-projectsgh-23908
@samarthrastogi samarthrastogi mentioned this issue Nov 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.0.1
Development

No branches or pull requests
2 participants
@bclozel @spring-projects-issues