Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Controller In Spring WebFlux [SPR-17031] #21569

Open
spring-issuemaster opened this issue Jul 11, 2018 · 3 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jul 11, 2018

Ankur Pathak opened SPR-17031 and commented

Their is no support for View Controller In Spring Web Flux.
Why not have addViewControllers(ViewControllerRegistry registry) method in WebFluxConfigurer similar to WebMvcConfigurer?

Their is no support for Welcome page like index.html also.


Affects: 5.0 GA

Reference URL: spring-projects/spring-boot#9785

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 12, 2018

Rossen Stoyanchev commented

Indeed no reason not to. I'm assigning to 5.x backlog only because it's a bit late for the 5.1 backlog.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 12, 2018

Rossen Stoyanchev commented

For the welcome page, we can make sure a default page can be mapped with a view controller but the actual welcome page would have to come from Boot.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 16, 2018

Ankur Pathak commented

Can't we have Servlets semantics for welcome page. We would register default.html, index.html, index.htm as default views in view registry and render them in order. In case we use explicit view mapped to root path, it will overwrite them.

@spring-issuemaster spring-issuemaster added this to the 5.x Backlog milestone Jan 11, 2019
@rstoyanchev rstoyanchev changed the title Support For View Controller In Spring WebFlux [SPR-17031] View Controller In Spring WebFlux [SPR-17031] Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.