MediaType.parseMediaTypes fails if the input contains a comma [SPR-17459]

[spring-projects-issues]

Fabian Kürten opened SPR-17459 and commented

For the class org.springframework.http.MediaType

Parsing a list of media types fails if a media type contains a comma ",".
For example this fails with InvalidMediaTypeException:

MediaType.parseMediaTypes("foo/bar;param=\",\"");

While the comma is the separator for different media types in a header my understanding is that it is legal to use tspecial characters (like comma) inside a quoted string.
However the implementation of parseMediaTypes tokenizes blindly by comma, ignoring quotes. The resulting parts are invalid media types (ends with an open quote) which leads to the exception.
 

---

Affects: 5.0.4, 5.1.2

Referenced from: commits f4b05dc, 7bbd4c6, ba3fef3

[spring-projects-issues]

Dimitrios Liapis commented

I could pick this up if no-one has done so already.

Is the OP's statement valid?

[spring-projects-issues]

Arjen Poutsma commented

I could pick this up if no-one has done so already.

Great!

Is the OP's statement valid?

It is. We currently do a simple comma-based tokenisation, see

spring-framework/spring-web/src/main/java/org/springframework/http/MediaType.java

Line 555 in 27e87e5

String[] tokens = StringUtils.tokenizeToStringArray(mediaTypes, ",");

Instead, we should check whether the comma is quoted, like we do when parsing a single media type:

spring-framework/spring-core/src/main/java/org/springframework/util/MimeTypeUtils.java

Line 207 in 847202c

Map<String, String> parameters = null;

[spring-projects-issues]

Dimitrios Liapis commented

Arjen Poutsma many thanks for the opportunity.

I've raised a PR: #2010