Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastByteArrayInputStream.read() wrong return value [SPR-17492] #22024

Closed
spring-projects-issues opened this issue Nov 13, 2018 · 2 comments
Closed

FastByteArrayInputStream.read() wrong return value [SPR-17492] #22024

spring-projects-issues opened this issue Nov 13, 2018 · 2 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.1.3

Comments

@spring-projects-issues
Copy link
Collaborator

janotav opened SPR-17492 and commented

The FastByteArrayInputStream.read() returns the byte as-is without the necessary conversion to the 0..255 int value and thus breaking the InputStream contract.

 

Referenced from: pull request #2016, and commits 35da9f1, 12f1682, ed9afa3

Backported to: 5.0.11, 4.3.21
@spring-projects-issues
Copy link
Collaborator Author

janotav commented

PR created: #2016

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Well spotted! Merged into master now, and to be backported to 5.0.x and 4.3.x ASAP.

@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.3 milestone Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.1.3
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues