Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastByteArrayInputStream.read() wrong return value [SPR-17492] #22024

Closed
spring-issuemaster opened this Issue Nov 13, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Nov 13, 2018

janotav opened SPR-17492 and commented

The FastByteArrayInputStream.read() returns the byte as-is without the necessary conversion to the 0..255 int value and thus breaking the InputStream contract.

 


Referenced from: pull request #2016, and commits 35da9f1, 12f1682, ed9afa3

Backported to: 5.0.11, 4.3.21

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Nov 13, 2018

janotav commented

PR created: #2016

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Nov 20, 2018

Juergen Hoeller commented

Well spotted! Merged into master now, and to be backported to 5.0.x and 4.3.x ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.