Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring MVC documentation has incorrect WebFlux reference #22270

Closed
pashazadeh opened this issue Jan 16, 2019 · 3 comments
Closed

Spring MVC documentation has incorrect WebFlux reference #22270

pashazadeh opened this issue Jan 16, 2019 · 3 comments
Assignees
@rstoyanchev
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Milestone
5.1.5

Comments

@pashazadeh
Copy link

It seems that the documents were written once for WebFlux and then copy-paste-and-edited for Spring MVC, but some of substitutions were missed.

For example in 1.1.2. Special Bean Types,

By “special beans” we mean Spring-managed Object instances that implement WebFlux framework contracts.

The following table lists the special beans detected by the DispatcherHandler:

Which should be replaced by Spring WebMVC and DisplatcherServlet.
@bclozel bclozel added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 17, 2019
@rstoyanchev rstoyanchev self-assigned this Jan 17, 2019
@rstoyanchev rstoyanchev added this to the 5.1.5 milestone Jan 17, 2019
@rstoyanchev
Copy link
Contributor

Thanks for the report. I wish they were written once :) ..

@rstoyanchev rstoyanchev added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 17, 2019
@rstoyanchev rstoyanchev changed the title Spring MVC 5 docments, has incorrect WebFlux references Spring MVC documentation has incorrect WebFlux reference Jan 17, 2019
@pashazadeh
Copy link
Author

pashazadeh commented Jan 19, 2019 •
edited

It seems the second guff: DispatcherHandler is not changed to DispatcherServlet yet.

@rstoyanchev
Copy link
Contributor

Fixing, thanks.

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.0.x labels Feb 7, 2019
Closed
jhoeller added a commit that referenced this issue Feb 7, 2019
@jhoeller
Typo in web documentation
74f832c 
Closes gh-22270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Projects
None yet
Milestone
5.1.5
Development

No branches or pull requests
5 participants
@bclozel @rstoyanchev @jhoeller @spring-projects-issues @pashazadeh