Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unguarded String concatenation for debug/trace logging #22874

Closed
jhoeller opened this issue May 2, 2019 · 0 comments
Closed

Avoid unguarded String concatenation for debug/trace logging #22874

jhoeller opened this issue May 2, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone
5.1.7

Comments

@jhoeller
Copy link
Contributor

jhoeller commented May 2, 2019

As a leftover from #21485, there is an issue in CachingResourceTransformer where it performs unguarded String concatenation for a trace log attempt. Along with an isTraceEnabled() guard at that position, several isDebugEnabled() checks are missing in less hotspot places as well.
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug labels May 2, 2019
@jhoeller jhoeller added this to the 5.1.7 milestone May 2, 2019
@jhoeller jhoeller self-assigned this May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
5.1.7
Development

No branches or pull requests
1 participant
@jhoeller