Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-allocate NoTransactionException in TransactionContextManager #23360

Closed
mp911de opened this issue Jul 25, 2019 · 1 comment
Closed

Pre-allocate NoTransactionException in TransactionContextManager #23360

mp911de opened this issue Jul 25, 2019 · 1 comment
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Milestone

Comments

@mp911de
Copy link
Member

mp911de commented Jul 25, 2019

NoTransactionException should be pre-allocated in org.springframework.transaction.reactive.TransactionContextManager to prevent expensive exception creation when calling TransactionContextManager.currentContext(). Ideally, this exception captures no stack trace, that is irrelevant in the context of reactive flows.

/cc @simonbasle @bsideup

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 25, 2019
@bsideup
Copy link

bsideup commented Jul 25, 2019

Consider using a stackless exception instead ( http://shipilev.net/blog/2014/exceptional-performance/#_conclusion )

Pre-allocated (aka cached, aka static) are hard to deal with in the debug mode (where we mutate them, necessary evil)

@jhoeller jhoeller added this to the 5.2 RC2 milestone Aug 1, 2019
@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on for: team-attention labels Aug 26, 2019
@jhoeller jhoeller added the in: data Issues in data modules (jdbc, orm, oxm, tx) label Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

6 participants