Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize initialization of empty request mapping conditions #25143

Closed
rstoyanchev opened this issue May 27, 2020 · 0 comments
Closed

Optimize initialization of empty request mapping conditions #25143

rstoyanchev opened this issue May 27, 2020 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Milestone
5.2.7

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented May 27, 2020 •
edited

This isn't very optimal currently in terms of object creation. A new instance is created for every empty condition. Internally collections are created and wrapped automatically without checking for empty input. Combining class and method level mappings repeats the process further.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task labels May 27, 2020
@rstoyanchev rstoyanchev added this to the 5.2.7 milestone May 27, 2020
@rstoyanchev rstoyanchev self-assigned this May 27, 2020
rstoyanchev added a commit that referenced this issue May 28, 2020
@rstoyanchev
Also use constant for custom mapping condition
a92f425 
See gh-25143
rstoyanchev added a commit that referenced this issue Jun 3, 2020
@rstoyanchev
Shared PathPatternParser instance
1e25556 
See gh-25143
rstoyanchev added a commit that referenced this issue Jun 3, 2020
@rstoyanchev
Pre-calculated RequestMappingInfo hashcode
8dc8d88 
See gh-25143
FelixFly pushed a commit to FelixFly/spring-framework that referenced this issue Aug 16, 2020
@rstoyanchev
Optimal initialization of empty request mapping conditions
ff38b9c 
Closes spring-projectsgh-25143
FelixFly pushed a commit to FelixFly/spring-framework that referenced this issue Aug 16, 2020
@rstoyanchev
Also use constant for custom mapping condition
3a9c753 
See spring-projectsgh-25143
FelixFly pushed a commit to FelixFly/spring-framework that referenced this issue Aug 16, 2020
@rstoyanchev
Shared PathPatternParser instance
dbf0824 
See spring-projectsgh-25143
FelixFly pushed a commit to FelixFly/spring-framework that referenced this issue Aug 16, 2020
@rstoyanchev
Pre-calculated RequestMappingInfo hashcode
0c5d78c 
See spring-projectsgh-25143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Milestone
5.2.7
Development

No branches or pull requests
1 participant
@rstoyanchev