Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring-framework-main-code attribute has not been expanded in docs #27041

Closed
philwebb opened this issue Jun 8, 2021 · 0 comments
Closed

spring-framework-main-code attribute has not been expanded in docs #27041

philwebb opened this issue Jun 8, 2021 · 0 comments
Assignees
@bclozel
Labels
type: documentation A documentation task
Milestone
5.3.8

Comments

@philwebb
Copy link
Member

philwebb commented Jun 8, 2021

@abelsromero spotted that https://docs.spring.io/spring-framework/docs/current/reference/html/web-reactive.html#webflux has {spring-framework-main-code} attributes that have not been expanded.

Both web frameworks mirror the names of their source modules ({spring-framework-main-code}/spring-webmvc[spring-webmvc] and {spring-framework-main-code}/spring-webflux[spring-webflux]) and co-exist side by side in the Spring Framework. Each module is optional. Applications can use one or the other module or, in some cases, both — for example, Spring MVC
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 8, 2021
@bclozel bclozel self-assigned this Jun 9, 2021
@bclozel bclozel added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 9, 2021
@bclozel bclozel added this to the 5.3.8 milestone Jun 9, 2021
@bclozel bclozel closed this as completed in c7c35af Jun 9, 2021
@sync-by-unito sync-by-unito bot mentioned this issue Jun 10, 2021
Closed
Zoran0104 pushed a commit to Zoran0104/spring-framework that referenced this issue Aug 20, 2021
@bclozel @Zoran0104
Fix missing attribute in reference documentation
96a2207 
This commit adds the missing `spring-framework-main-code` asciidoctor
attribute in the reference documentation.

Fixes spring-projectsgh-27041
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@bclozel @lxbzmy
Fix missing attribute in reference documentation
034624d 
This commit adds the missing `spring-framework-main-code` asciidoctor
attribute in the reference documentation.

Fixes spring-projectsgh-27041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: documentation A documentation task
Projects
None yet
Milestone
5.3.8
Development

No branches or pull requests
3 participants
@bclozel @philwebb @spring-projects-issues