Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide repackaged version of JavaPoet #27828

Closed
snicoll opened this issue Dec 16, 2021 · 2 comments
Closed

Provide repackaged version of JavaPoet #27828

snicoll opened this issue Dec 16, 2021 · 2 comments
Assignees
@snicoll
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.0.0-M3

Comments

@snicoll
Copy link
Member

snicoll commented Dec 16, 2021

Our AOT processing needs a code generation library and we're quite happy using JavaPoet in Spring Native. It would be quite unusual for the core container to have a direct dependency on a third-party so the plan is to jarjar it in org.springframework.javapoet in the spring-core module.
@snicoll snicoll added type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Dec 16, 2021
@snicoll snicoll added this to the 6.0.0-M3 milestone Dec 16, 2021
@snicoll snicoll self-assigned this Dec 16, 2021
@snicoll snicoll changed the title Provide repackage version of Javapoet Provide repackaged version of Javapoet Dec 16, 2021
@jhoeller jhoeller changed the title Provide repackaged version of Javapoet Provide repackaged version of JavaPoet Dec 16, 2021
@jhoeller jhoeller added the in: core Issues in core modules (aop, beans, core, context, expression) label Dec 16, 2021
snicoll added a commit to snicoll/spring-framework that referenced this issue Jan 6, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
704e1a0 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Jan 6, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
f61ad47 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Jan 6, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
61e15d9 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Jan 10, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
467dd75 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
@snicoll
Copy link
Member Author

snicoll commented Jan 11, 2022

We've decided to depend on JavaPoet directly for now with an optional dependency in modules that require it.

@snicoll snicoll closed this as completed Jan 11, 2022
@snicoll snicoll removed this from the 6.0.0-M3 milestone Jan 11, 2022
@snicoll snicoll added the status: declined A suggestion or change that we don't feel we should currently apply label Jan 11, 2022
@snicoll snicoll removed their assignment Jan 11, 2022
@snicoll
Copy link
Member Author

snicoll commented Feb 3, 2022

With our design evolving where certain components can provide both the regular runtime behavior and something that can generate a pre-processed version of it, it became apparent that it's odd to rely on an optional dependency of javapoet.

We've decided to give the repackaging another try.

@snicoll snicoll reopened this Feb 3, 2022
@snicoll snicoll removed the status: declined A suggestion or change that we don't feel we should currently apply label Feb 3, 2022
@snicoll snicoll self-assigned this Feb 3, 2022
@snicoll snicoll added this to the 6.0.0-M3 milestone Feb 3, 2022
snicoll added a commit to snicoll/spring-framework that referenced this issue Feb 3, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
d0b6612 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Feb 3, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
cff4346 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Feb 3, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
bb06af0 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Feb 4, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
42243d9 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Feb 7, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
ce7513e 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Feb 7, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
dd7ec1a 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Feb 9, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
f9ccac0 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
snicoll added a commit to snicoll/spring-framework that referenced this issue Feb 10, 2022
@snicoll
Repackage Javapoet in org.springframework.javapoet
b74b86b 
This commit repackages the Javapoet library into spring-core so that it
can be used by the AOT engine without requiring a specific version.

Closes spring-projectsgh-27828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M3
Development

No branches or pull requests
2 participants
@snicoll @jhoeller