Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalise merged BeanDefinition resolution for inner beans #28093

Closed
snicoll opened this issue Feb 22, 2022 · 2 comments
Closed

Rationalise merged BeanDefinition resolution for inner beans #28093

snicoll opened this issue Feb 22, 2022 · 2 comments
Assignees
@snicoll
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.0.0-M3

Comments

@snicoll
Copy link
Member

snicoll commented Feb 22, 2022

There are more places where we need to create a beanName for an inner bean definition so rather than copy/pasting those, it would be better to have that logic in a single place.
@snicoll snicoll added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Feb 22, 2022
@snicoll snicoll added this to the 6.0.0-M3 milestone Feb 22, 2022
@snicoll snicoll self-assigned this Feb 22, 2022
@snicoll
Copy link
Member Author

snicoll commented Feb 22, 2022

I was under the impression I could add that in BeanFactoryUtils but this introduces a package tangle. @jhoeller any idea?

@snicoll snicoll changed the title Rationalise inner bean name creation Rationalise merged BeanDefinition resolution for inner beans Mar 6, 2022
@snicoll
Copy link
Member Author

snicoll commented Mar 6, 2022

It turns out that the way a RootBeanDefinition for an inner bean is required and it goes beyons getting a bean name for it. I've updated the issue accordingly.

snicoll added a commit to snicoll/spring-framework that referenced this issue Mar 6, 2022
@snicoll
Expose a way to resolved a merged inner bean definition
929b5a0 
This commit extracts the logic of resolving a merged bean definition for
an inner bean to a public method so that other components can reuse it.

Closes spring-projectsgh-28093
snicoll added a commit to snicoll/spring-framework that referenced this issue Mar 7, 2022
@snicoll
Expose a way to resolved a merged inner bean definition
fc4312b 
This commit extracts the logic of resolving a merged bean definition for
an inner bean to a public method so that other components can reuse it.

Closes spring-projectsgh-28093
@snicoll snicoll closed this as completed in cc57b55 Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M3
Development

No branches or pull requests
1 participant
@snicoll