Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that nullable annotations are from org.springframework.lang #28410

Closed
philwebb opened this issue May 3, 2022 · 0 comments
Closed

Check that nullable annotations are from org.springframework.lang #28410

philwebb opened this issue May 3, 2022 · 0 comments
Assignees
@philwebb
Labels
type: task A general task
Milestone
5.3.20

Comments

@philwebb
Copy link
Member

philwebb commented May 3, 2022

It's quite easy to accidentally import the wrong @Nullable annotation. We can add a checkstyle rule to make sure it doesn't happen.
@philwebb philwebb added this to the 6.0.0-M4 milestone May 3, 2022
@philwebb philwebb added the type: enhancement A general enhancement label May 3, 2022
@philwebb philwebb self-assigned this May 3, 2022
jhoeller added a commit that referenced this issue May 5, 2022
@jhoeller
Preserve javax nullability annotations for AOP Alliance fork
17c778e 
See gh-28410
@jhoeller jhoeller added type: task A general task and removed type: enhancement A general enhancement labels May 5, 2022
@jhoeller jhoeller modified the milestones: 6.0.0-M4, 5.3.20 May 5, 2022
jhoeller added a commit that referenced this issue May 5, 2022
@jhoeller
Check that nullable annotations are from org.springframework.lang
f963fc5 
Closes gh-28410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: task A general task
Projects
None yet
Milestone
5.3.20
Development

No branches or pull requests
2 participants
@philwebb @jhoeller