Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce attribute support in Kotlin RouterFunction DSL #28567

Closed
christophejan opened this issue Jun 5, 2022 · 0 comments
Closed

Introduce attribute support in Kotlin RouterFunction DSL #28567

christophejan opened this issue Jun 5, 2022 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement
Milestone

Comments

@christophejan
Copy link
Contributor

christophejan commented Jun 5, 2022

On current spring framework version (5.3.19), RouterFunction attributes are not supported by RouterFunction Kotlin DSL.

RouterFunction attributes is currently supported by Java Builder :


But RouterFunction attributes support is missing from all Kotlin DSL :

@christophejan christophejan changed the title RouterFunction attributes support is missing on all Kotlin DSL RouterFunction attributes support is missing from all Kotlin DSL Jun 5, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 5, 2022
christophejan added a commit to christophejan/spring-framework that referenced this issue Jun 5, 2022
@poutsma poutsma self-assigned this Jun 8, 2022
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support labels Jun 8, 2022
@poutsma poutsma changed the title RouterFunction attributes support is missing from all Kotlin DSL Introduce attribute support in Kotlin RouterFunction DSL Jun 8, 2022
@poutsma poutsma added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 8, 2022
@poutsma poutsma added this to the 6.0.0-M5 milestone Jun 8, 2022
@poutsma poutsma closed this as completed in bbabf8d Jun 8, 2022
poutsma added a commit that referenced this issue Jun 8, 2022
* gh-28567:
  Polish
  Add minimal Kotlin DSL RouterFunction attributes support
  Add test case on nested RouterFunction attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants