Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using RuntimeHintsUtils to register SynthesizedAnnotation proxies #29059

Closed
sbrannen opened this issue Sep 2, 2022 · 4 comments
Closed

Stop using RuntimeHintsUtils to register SynthesizedAnnotation proxies #29059

sbrannen opened this issue Sep 2, 2022 · 4 comments
Assignees
@sdeleuze
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.0.0-M6

Comments

@sbrannen
Copy link
Member

sbrannen commented Sep 2, 2022

Due to #29053, we should stop using RuntimeHintsUtils to register SynthesizedAnnotation proxies and verify that all smoke tests for our native image support still pass.

See also:
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Sep 2, 2022
@sbrannen sbrannen added this to the 6.0.0-M6 milestone Sep 2, 2022
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 2, 2022
@sbrannen
Stop registering SynthesizedAnnotation proxies in spring-test
dadfdb9 
See spring-projectsgh-29059
@sdeleuze sdeleuze mentioned this issue Sep 6, 2022
Closed
@sdeleuze
Copy link
Contributor

sdeleuze commented Sep 6, 2022

Temporarily reverted in order to let the time to portfolio projects to remove RuntimeHintsUtils usage.

@sdeleuze sdeleuze reopened this Sep 6, 2022
@snicoll
Copy link
Member

snicoll commented Sep 7, 2022

Shouldn't #29058 only be reopened? I understand that a single commit removed the usage and the class but perhaps the usage can be removed and this issue be closed?

@sdeleuze
Copy link
Contributor

sdeleuze commented Sep 7, 2022

I should be able to restore the commit end of the day, so I think it is ok to just wait that to restore the original commit that will close those 2 issues at the same time.

@sdeleuze
Copy link
Contributor

sdeleuze commented Sep 7, 2022

After a second thought, I will follow your proposal and refine the commit to just remove the usage. I does not hurt to have 2 separated commits indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
3 participants
@sbrannen @sdeleuze @snicoll