Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class meta-annotated with @Reflective and annotated with @RegisterReflectionForBinding is only processed by SimpleReflectiveProcessor #29193

Closed
wilkinsona opened this issue Sep 23, 2022 · 0 comments
Closed

Class meta-annotated with @Reflective and annotated with @RegisterReflectionForBinding is only processed by SimpleReflectiveProcessor #29193

wilkinsona opened this issue Sep 23, 2022 · 0 comments
Assignees
@wilkinsona
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Milestone
6.0.0-RC1

Comments

@wilkinsona
Copy link
Member

Affects: 6.0.0-M5

I am trying to use @RegisterReflectionForBinding on a class annotated with Spring Boot's @Endpoint. @Endpoint is meta-annotated with @Reflective. When the annotated class is processed by ReflectiveRuntimeHintsRegistrar, SimpleReflectiveProcessor from @Reflective is used but RegisterReflectionForBindingProcessor from @ RegisterReflectionForBinding is not.
@wilkinsona wilkinsona mentioned this issue Sep 23, 2022
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 23, 2022
@sdeleuze sdeleuze self-assigned this Sep 23, 2022
@sdeleuze sdeleuze added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 23, 2022
@sdeleuze sdeleuze added this to the 6.0.0-RC1 milestone Sep 23, 2022
wilkinsona added a commit to wilkinsona/spring-framework that referenced this issue Sep 23, 2022
@wilkinsona
Consider all processors when processing @Reflective
e84264a 
Previously, only the first occurance of `@Reflective` and its
processor was considered. When `@Reflective` appeared twice on a type
due to meta-annotations or inheritance, this resulted in other
processors being ignored and hints were missing as a result.

This commit updates ReflectiveRuntimeHintsRegistrar to consider
every occurance of `@Reflective` found in the type hierarchy,
and to then use the processors from each of them.

Fixes spring-projectsgh-29193
wilkinsona added a commit to wilkinsona/spring-framework that referenced this issue Sep 23, 2022
@wilkinsona
Consider all processors when processing @Reflective
641fecf 
Previously, only the first occurance of `@Reflective` and its
processor was considered. When `@Reflective` appeared twice on a type
due to meta-annotations or inheritance, this resulted in other
processors being ignored and hints were missing as a result.

This commit updates ReflectiveRuntimeHintsRegistrar to consider
every occurance of `@Reflective` found in the type hierarchy,
and to then use the processors from each of them.

Fixes spring-projectsgh-29193
wilkinsona added a commit to wilkinsona/spring-framework that referenced this issue Sep 23, 2022
@wilkinsona
Consider all processors when processing @Reflective
dcac27c 
Previously, only the first occurance of `@Reflective` and its
processor was considered. When `@Reflective` appeared twice on a type
due to meta-annotations or inheritance, this resulted in other
processors being ignored and hints were missing as a result.

This commit updates ReflectiveRuntimeHintsRegistrar to consider
every occurance of `@Reflective` found in the type hierarchy,
and to then use the processors from each of them.

Fixes spring-projectsgh-29193
wilkinsona added a commit to wilkinsona/spring-framework that referenced this issue Sep 23, 2022
@wilkinsona
Consider all processors when processing @Reflective
7e9efd2 
Previously, only the first occurance of `@Reflective` and its
processor was considered. When `@Reflective` appeared twice on a type
due to meta-annotations or inheritance, this resulted in other
processors being ignored and hints were missing as a result.

This commit updates ReflectiveRuntimeHintsRegistrar to consider
every occurance of `@Reflective` found in the type hierarchy,
and to then use the processors from each of them.

Fixes spring-projectsgh-29193
@sdeleuze sdeleuze assigned wilkinsona and unassigned sdeleuze Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
3 participants
@sdeleuze @wilkinsona @spring-projects-issues