New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JettyWebSocketCreator referenced from a method is not visible from class loader with Jetty10RequestUpgradeStrategy
#29256
Comments
Jetty10RequestUpgradeStrategy
Jetty10RequestUpgradeStrategy
Jetty10RequestUpgradeStrategy
@2is10, I've updated how |
@rstoyanchev Missed the earlier notification. Will try this out. Thank you! |
Thanks, that would be great! I can't reproduce the issue myself, but I did try with a sample to confirm the change works. |
Hmm. |
@2is10 You can configure additional repositories like this: <repositories>
<repository>
<id>spring-milestones</id>
<name>Spring Milestones</name>
<url>https://repo.spring.io/milestone</url>
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>
<repository>
<id>spring-snapshots</id>
<name>Spring Snapshots</name>
<url>https://repo.spring.io/snapshot</url>
<releases>
<enabled>false</enabled>
</releases>
</repository>
</repositories> or this: repositories {
mavenCentral()
maven { url 'https://repo.spring.io/milestone' }
maven { url 'https://repo.spring.io/snapshot' }
} |
Thanks @bclozel. I just tried again with 5.3.26-SNAPSHOT.
The method invoked by reflection there is
That returns |
Rossen did verify the fix with a sample, but maybe your application has a different setup or use case. Could you share a minimal sample that demonstrates the issue? |
Our server code is nearly 10 years old, quite large, and doesn’t use Spring Boot. It would take me hours to produce a minimal sample. Here’s an idea. Could you run your sample with a breakpoint in |
Affects: 5.3.23
I have a working websocket configured and running on Spring 5.3.23 with Jetty 9.4.48.v20220622. When I attempt to upgrade to Jetty 10.0.12, the server responds with 500 Server Error when clients try to open a websocket connection due to the following exception:
The
IllegalArgumentException
originates injava.lang.reflect.Proxy.ensureVisible
, which is attempting to ensure the visibility ofJettyWebSocketCreator
to aorg.eclipse.jetty.webapp.WebAppClassLoader
. Note thatJettyWebSocketCreator
has already been successfully loaded by the main class loader. For some reason though, theWebAppClassLoader
can't find it.The text was updated successfully, but these errors were encountered: