Add reflection hints for EmbeddedDatabaseFactory$EmbeddedDataSourceProxy#shutdown #29259
Assignees
Labels
in: data
Issues in data modules (jdbc, orm, oxm, tx)
theme: aot
An issue related to Ahead-of-time processing
type: enhancement
A general enhancement
Milestone
Comments
sdeleuze
added
in: data
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this issue
Oct 5, 2022
This commit adds a reflection hint on EmbeddedDatabaseFactory$EmbeddedDataSourceProxy#shutdown when EmbeddedDatabaseFactory is reachable in order to allow its usage as bean destroy method. Closes spring-projectsgh-29259
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this issue
Oct 5, 2022
This commit adds a reflection hints on EmbeddedDatabaseFactory$EmbeddedDataSourceProxy#shutdown when EmbeddedDatabaseFactory is reachable in order to allow its usage as bean destroy method. Closes spring-projectsgh-29259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in oracle/graal#5073, our
session-jdbcAOT smoke test sample currently registers reflection entry fororg.springframework.jdbc.datasource.embedded.EmbeddedDatabase#shutdowninstead oforg.springframework.jdbc.datasource.embedded.EmbeddedDatabaseFactory$EmbeddedDataSourceProxy#shutdown.It comes from EmbeddedDataSourceConfiguration and the inference is done here. The reflection registration on the class instance is needed to make it work on GraalVM 22.3 (we are not sure why that does not break on 22.2). By design, we can't know the concrete type of the
EmbeddedDatabasewithout instantiating the bean which is not possible at AOT stage I think.As discussed with @wilkinsona in spring-projects/spring-boot#32581, it should be Spring Framework responsibility to provide an arrangement that works out of the box. Providing hints with a type reachable condition on
EmbeddedDatabaseFactoryis IMO a good enough way to achieve that.The text was updated successfully, but these errors were encountered: