Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize URIs returned from FileSystemResource.getURI() #29275

Closed
sbrannen opened this issue Oct 7, 2022 · 0 comments
Closed

Normalize URIs returned from FileSystemResource.getURI() #29275

sbrannen opened this issue Oct 7, 2022 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.0.0-RC1

Comments

@sbrannen
Copy link
Member

sbrannen commented Oct 7, 2022

Due to changes made in conjunction with #29163, the URI for a FileSystemResource returned from PathMatchingResourcePatternResolver.getResources(String) now includes an additional two slashes (file:///...) instead of one (file:/...) as was previously the case.

In order not to break existing code that expects a single leading slash, we should see if we can modify the behavior of FileSystemResource so that file: URIs returned from getURI() contain a single slash.
@sbrannen sbrannen added type: regression A bug that is also a regression in: core Issues in core modules (aop, beans, core, context, expression) labels Oct 7, 2022
@sbrannen sbrannen self-assigned this Oct 7, 2022
@sbrannen sbrannen added this to the 6.0.0-RC1 milestone Oct 7, 2022
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Oct 7, 2022
@sbrannen
Test status quo for URI/URL for scanned filesystem resources
8caed88 
See spring-projectsgh-29275
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Oct 7, 2022
@sbrannen
Disable failing test until spring-projectsgh-29275 is addressed
af617c7
@sbrannen sbrannen changed the title URI for scanned filesystem resources now includes three leading slashes Normalize URIs returned from FileSystemResource.getURI() Oct 7, 2022
@sbrannen sbrannen added type: enhancement A general enhancement and removed type: regression A bug that is also a regression labels Oct 7, 2022
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Oct 7, 2022
@sbrannen
Introduce unit tests for spring-projectsgh-29275
6698943
sbrannen added a commit that referenced this issue Oct 7, 2022
@sbrannen
Throw IOException in FileSystemResource.getURI() for consistency
1d05274 
See gh-29275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
1 participant
@sbrannen