Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostics in SpEL for matches operator #30144

Closed
sbrannen opened this issue Mar 19, 2023 · 0 comments
Closed

Improve diagnostics in SpEL for matches operator #30144

sbrannen opened this issue Mar 19, 2023 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.0.7

Comments

@sbrannen
Copy link
Member

Supplying a large regular expression to the matches operator in a SpEL expression can result in errors that are not very helpful to the user.

We should therefore improve the diagnostics so that the user is provided a meaningful error message.
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Mar 19, 2023
@sbrannen sbrannen added this to the 6.0.7 milestone Mar 19, 2023
@sbrannen sbrannen self-assigned this Mar 19, 2023
@sbrannen sbrannen added the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Mar 19, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x labels Mar 19, 2023
@github-actions github-actions bot mentioned this issue Mar 19, 2023
Closed
@github-actions github-actions bot mentioned this issue Mar 20, 2023
Closed
izeye added a commit to izeye/spring-framework that referenced this issue Mar 23, 2023
@izeye
Update versions in Javadoc for spring-projectsgh-30140, spring-projec…
e75a4ff 
…tsgh-30142, and spring-projectsgh-30144

See spring-projectsgh-30140
See spring-projectsgh-30142
See spring-projectsgh-30144
@izeye izeye mentioned this issue Mar 23, 2023
Closed
jgallimore pushed a commit to tomitribe/spring-framework that referenced this issue Apr 3, 2023
@sbrannen @jgallimore
Improve diagnostics in SpEL for matches operator
fec6995 
Supplying a large regular expression to the `matches` operator in a
SpEL expression can result in errors that are not very helpful to the
user.

This commit improves the diagnostics in SpEL for the `matches` operator
by throwing a SpelEvaluationException with a meaningful error message
to better assist the user.

Closes spring-projectsgh-30144
@cxronen cxronen mentioned this issue Apr 13, 2023
Open
@oscardatastream oscardatastream mentioned this issue Apr 26, 2023
Open
@cxronen cxronen mentioned this issue May 25, 2023
Open
@diogopcx diogopcx mentioned this issue Jun 27, 2023
Open
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@sbrannen @mdeinum
Improve diagnostics in SpEL for matches operator
b20fb4a 
Supplying a large regular expression to the `matches` operator in a
SpEL expression can result in errors that are not very helpful to the
user.

This commit improves the diagnostics in SpEL for the `matches` operator
by throwing a SpelEvaluationException with a meaningful error message
to better assist the user.

Closes spring-projectsgh-30144
@AASMACMX AASMACMX mentioned this issue Apr 26, 2023
Open
@cxronen cxronen mentioned this issue Jul 19, 2023
Open
@AASMACMX AASMACMX mentioned this issue Jul 10, 2023
Open
@apcxtest apcxtest mentioned this issue Aug 17, 2023
Closed
@Sang140790 Sang140790 mentioned this issue Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.7
Development

No branches or pull requests
1 participant
@sbrannen