A clean build leads to "Failed to download playbook"

[rstoyanchev]

$ ./gradlew clean build
> Task :framework-docs:antora FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':framework-docs:antora'.
> Failed to calculate the value of task ':framework-docs:antora' property 'args'.
   > Failed to download playbook from specified provider { host = 'github.com' repository = 'spring-projects/spring-framework' branch = 'docs-build' path = 'lib/antora/templates/per-branch-antora-playbook.yml' }.

This looks related to the recent change #30465 to download to the build directory. The antora task seems to download the playbook quite early as part of registration. I can see in the logs the playbook is successfully retrieved, but the build directory probably doesn't exist yet.

Removing the dependency on "check" it no longer fails. However, the task also no longer gets run as part of the build to flag potential documentation issues.

I'm not sure if there is room for improvement on the Antora side. I find that both the "check" to "antora" dependency as well as the choice to cache the playbook under the build directory are reasonable choices.

[rstoyanchev]

We've decided to revert the change to download the playbook to the build directory, as well as to remove the task dependency from "check" to "antora", also because it runs every time (regardless of changes) and it is not very fast. Instead we'll have the "antora" task run as part of the CI build, or otherwise we'll run it manually locally.