Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplicationListenerMethodAdapter inconsistently publishes events from CompletableFuture #30578

Closed
jhoeller opened this issue Jun 1, 2023 · 0 comments
Closed

ApplicationListenerMethodAdapter inconsistently publishes events from CompletableFuture #30578

jhoeller opened this issue Jun 1, 2023 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
6.0.10

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Jun 1, 2023

For values returned from an @EventListener method, ApplicationListenerMethodAdapter detects arrays/collections and publishes every single element as an event. However, for its CompletionStage check (as applied to a CompletableFuture), it always publishes the given Object as-is. It should delegate to the publishEvents methods with its arrays/collections check as well.
@jhoeller jhoeller added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Jun 1, 2023
@jhoeller jhoeller added this to the 6.0.10 milestone Jun 1, 2023
@jhoeller jhoeller self-assigned this Jun 1, 2023
@jhoeller jhoeller added the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Jun 2, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x labels Jun 2, 2023
@github-actions github-actions bot mentioned this issue Jun 2, 2023
Closed
jhoeller added a commit that referenced this issue Jun 2, 2023
@jhoeller
Consistently publish events from CompletableFuture
1240fb6 
Closes gh-30578

(cherry picked from commit b738a20)
mdeinum pushed a commit to mdeinum/spring-framework that referenced this issue Jun 29, 2023
@jhoeller @mdeinum
Consistently publish events from CompletableFuture
8fabb40 
Closes spring-projectsgh-30578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
6.0.10
Development

No branches or pull requests
1 participant
@jhoeller