Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent ProxyCallbackFilter#equals/hashCode methods in CglibAopProxy #30616

Closed
github-actions bot opened this issue Jun 8, 2023 · 1 comment
Closed

Inconsistent ProxyCallbackFilter#equals/hashCode methods in CglibAopProxy #30616

github-actions bot opened this issue Jun 8, 2023 · 1 comment
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
5.3.28

Comments

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Backport of gh-30615
@github-actions github-actions bot added in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Jun 8, 2023
@github-actions github-actions bot added this to the 5.3.28 milestone Jun 8, 2023
@jhoeller jhoeller self-assigned this Jun 8, 2023
jhoeller added a commit that referenced this issue Jun 8, 2023
@jhoeller
Consistent ProxyCallbackFilter#equals/hashCode methods
0641183 
Opaque check in equals instead; no consideration of optimize flag.

Closes gh-30616
@jhoeller
Copy link
Contributor

jhoeller commented Jun 8, 2023

This has been separately addressed with a minimal change in the 5.3.x branch: the opaque check is in equals instead and the optimize flag is not considered for CallbackFilter equality at all anymore. This makes equals/hashCode internally consistent but is not as optimal as the advisor key arrangement in 6.0.10, neither in terms of performance nor in terms of memory leaks.

@jhoeller jhoeller closed this as completed Jun 8, 2023
jhoeller added a commit that referenced this issue Jun 12, 2023
@jhoeller
Reuse method cache from original proxy factory (aligned with 6.0.x)
70be9af 
See gh-30616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
5.3.28
Development

No branches or pull requests
1 participant
@jhoeller