Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise log level to warn when configuration class enhancement cannot apply due to circular reference #31102

Closed
jhoeller opened this issue Aug 23, 2023 · 0 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@jhoeller
Copy link
Contributor

Our existing log message for a circular reference to the configuration class is not ideally worded since it suggests that the configuration class cannot be enhanced whereas it actually can be enhanced but effectively won't use the enhanced class. Also, it suggests declaring the affected @Bean method as static but could also mention that the configuration class should be declared as proxyBeanMethods=false if enhancement is not needed anyway.

Most importantly, that log message can easily be missed at info level, so we should raise it to warn level.

Related PRs: #22992, #24356.

@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Aug 23, 2023
@jhoeller jhoeller added this to the 6.1.0-RC1 milestone Aug 23, 2023
@jhoeller jhoeller self-assigned this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant