Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enhance @Configuration bean definition #22992

Closed
wants to merge 1 commit into from

Conversation

lgxbslgx
Copy link
Contributor

Cannot enhance @configuration bean definition if its singleton instance has been created too early.
Add the corresponding testcase.
Fix #22990.

Cannot enhance @configuration bean definition if its
singleton instance has been created too early.
Add the corresponding testcase.
See spring-projects#22990.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 18, 2019
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label May 23, 2019
@sbrannen sbrannen requested a review from jhoeller May 23, 2019 13:55
@snicoll
Copy link
Member

snicoll commented Aug 23, 2023

Thanks for the PR but skipping the enhancement step for circular reference scenarios where the enhanced class won't be used is not going to provide anything. This scenario should be fixed at the user level anyway and we're not keen to add a change for that scenario. Thanks anyway for the PR.

@snicoll snicoll closed this Aug 23, 2023
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
5 participants