Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ReactorResourceFactory lifecycle-aware #31178

Closed
sdeleuze opened this issue Sep 6, 2023 · 0 comments
Closed

Make ReactorResourceFactory lifecycle-aware #31178

sdeleuze opened this issue Sep 6, 2023 · 0 comments
Assignees
@sdeleuze
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.1.0-M5

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Sep 6, 2023

In order to improve the compatibility with JVM Checkpoint Restore (aka CRaC), ReactorResourceFactory should implement Lifecycle interface.
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Sep 6, 2023
@sdeleuze sdeleuze added this to the 6.1.0-RC1 milestone Sep 6, 2023
@sdeleuze sdeleuze self-assigned this Sep 6, 2023
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 6, 2023
@sdeleuze
Make ReactorResourceFactory lifecycle-aware
5eb782d 
With this commit, ReactorResourceFactory now implements
Lifecycle which allows supporting JVM Checkpoint Restore
in Spring Boot with Reactor Netty server, and helps
to support Reactor Netty client as well.

Closes spring-projectsgh-31178
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 6, 2023
@sdeleuze
Make ReactorResourceFactory lifecycle-aware
c6acc2f 
With this commit, ReactorResourceFactory now implements
Lifecycle which allows supporting JVM Checkpoint Restore
in Spring Boot with Reactor Netty server, and helps
to support Reactor Netty client as well.

Closes spring-projectsgh-31178
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 6, 2023
@sdeleuze
Make ReactorResourceFactory lifecycle-aware
635bbb0 
With this commit, ReactorResourceFactory now implements
Lifecycle which allows supporting JVM Checkpoint Restore
in Spring Boot with Reactor Netty server, and helps
to support Reactor Netty client as well.

Closes spring-projectsgh-31178
@sdeleuze sdeleuze mentioned this issue Sep 6, 2023
Closed
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 6, 2023
@sdeleuze
Polish ReactorResourceFactoryTests
ab2ad74 
See spring-projectsgh-31178
@sdeleuze sdeleuze mentioned this issue Sep 6, 2023
Closed
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 8, 2023
@sdeleuze
Refine ReactorResourceFactory Javadoc
6251b28 
Provides more details about
stop/restart scenario.

See spring-projectsgh-31178
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 8, 2023
@sdeleuze
Refine ReactorResourceFactory Javadoc
1c52c14 
Provides more details about stop/restart
scenario.

See spring-projectsgh-31178
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 8, 2023
@sdeleuze
Refine ReactorResourceFactory Javadoc
da7ad71 
Provides more details about stop/restart
scenario.

See spring-projectsgh-31178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M5
Development

No branches or pull requests
1 participant
@sdeleuze