Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit AOT support for generic constructor argument values #31420

Closed
snicoll opened this issue Oct 12, 2023 · 0 comments
Closed

Revisit AOT support for generic constructor argument values #31420

snicoll opened this issue Oct 12, 2023 · 0 comments
Assignees
@snicoll
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.1.0-RC2

Comments

@snicoll
Copy link
Member

snicoll commented Oct 12, 2023

Now that #27920 has been implemented, constructor resolver seems to work against generic constructor argument values. We should generate the code for them. It's pretty common in XML configuration. A simple bean with constructor-arg value="..." fails for this reason at the moment.
@snicoll snicoll added type: bug A general bug theme: aot An issue related to Ahead-of-time processing labels Oct 12, 2023
@snicoll snicoll added this to the 6.1.x milestone Oct 12, 2023
@snicoll snicoll self-assigned this Oct 12, 2023
@snicoll snicoll mentioned this issue Oct 12, 2023
Closed
@snicoll snicoll added type: enhancement A general enhancement and removed type: bug A general bug labels Oct 12, 2023
snicoll added a commit to snicoll/spring-framework that referenced this issue Oct 12, 2023
@snicoll
Add AOT support for generic constructor argument values
4b5d038 
This commit improves compatibility with the core container when running
in AOT mode by adding support for generic constructor argument values.

Previously, these were ignored altogether. We now have code generation
support for them as well as resolution that is similar to what
AbstractAutowiredCapableBeanFactory does in a regular runtime.

Closes spring-projectsgh-31420
@jhoeller jhoeller added the in: core Issues in core modules (aop, beans, core, context, expression) label Oct 13, 2023
@snicoll snicoll modified the milestones: 6.1.x, 6.1.0-RC2 Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-RC2
Development

No branches or pull requests
2 participants
@snicoll @jhoeller