Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log4jLog needs to re-resolve ExtendedLogger on deserialization (for compatibility with Log4J 2.21) #31582

Closed
jhoeller opened this issue Nov 9, 2023 · 0 comments
Closed

Log4jLog needs to re-resolve ExtendedLogger on deserialization (for compatibility with Log4J 2.21) #31582

jhoeller opened this issue Nov 9, 2023 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.0.14

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Nov 9, 2023

Log4J 2.21 holds a ThreadLocal instance in a non-transient field which breaks serialization behind our Commons Logging adapter. Since we re-resolve the delegate on deserialization for SLF4J already, we should do the same for Log4J.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Nov 9, 2023
@jhoeller jhoeller added this to the 6.0.14 milestone Nov 9, 2023
@jhoeller jhoeller self-assigned this Nov 9, 2023
@jhoeller jhoeller added the for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x label Nov 9, 2023
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x labels Nov 9, 2023
@github-actions github-actions bot mentioned this issue Nov 9, 2023
Closed
jhoeller added a commit that referenced this issue Nov 9, 2023
@jhoeller
Log4jLog re-resolves ExtendedLogger on deserialization
f97e819 
This is necessary for compatibility with Log4J 2.21, analogous to the existing re-resolution in Spring's SLF4J adapter.

Closes gh-31582

(cherry picked from commit 1e78cc3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.14
Development

No branches or pull requests
1 participant
@jhoeller