Exceptions thrown by custom error handlers are not recorded in RestTemplate observations #32063
Assignees
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
theme: observability
An issue related to observability and tracing
type: backport
An issue that is a backport of another issue to a maintenance branch
type: bug
A general bug
Milestone
Comments
github-actions
bot
added
in: web
bclozel
added a commit
that referenced
this issue
Jan 22, 2024
Prior to this commit, the `RestTemplate` observation instrumentation would only record `RestClientException` and `IOException` as errors in the observation. Other types of errors can be thrown by custom components, such as `ResponseErrorHandler` and in this case they aren't recorded with the observation. Also, the current instrumentation does not create any observation scope around the execution. While this would have a limited benefit as no application code is executed there, developers could set up custom components (such as, again, `ResponseErrorHandler`) that could use contextual logging with trace ids. This commit ensures that all `Throwable` are recorded as errors with the observations and that an observation `Scope` is created around the execution of the client exchange. Fixes gh-32063
|
Fixed via b484ab1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Backport of gh-32060
The text was updated successfully, but these errors were encountered: