Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Jetty 10 compatibility in JettyClientHttpResponse #32337

Closed
poutsma opened this issue Feb 28, 2024 · 3 comments
Closed

Restore Jetty 10 compatibility in JettyClientHttpResponse #32337

poutsma opened this issue Feb 28, 2024 · 3 comments
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression
Milestone
5.3.33

Comments

@poutsma
Copy link
Contributor

poutsma commented Feb 28, 2024 •
edited

As part of 186d6e3, support for Jetty 10 was mistakenly removed. It should be restored.

Thanks to @sbordet for noting this regression in 186d6e3#commitcomment-139066680.
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression labels Feb 28, 2024
@poutsma poutsma added this to the 5.3.33 milestone Feb 28, 2024
@poutsma poutsma self-assigned this Feb 28, 2024
poutsma referenced this issue Feb 28, 2024
@poutsma
Guard against multiple body subscriptions
186d6e3 
Before this commit, the Jetty connector did not have any
safeguard against multiple body subscriptions. Such as check has now
been added.

See gh-32100
Closes gh-32101
poutsma added a commit that referenced this issue Feb 28, 2024
@poutsma
Restore Jetty 10 compatibility in JettyClientHttpResponse
e44f84e 
Closes gh-32337
@poutsma
Copy link
Contributor Author

poutsma commented Feb 28, 2024 •
edited

Resolved in #e44f84e.

@poutsma poutsma closed this as completed Feb 28, 2024
@poutsma
Copy link
Contributor Author

poutsma commented Feb 28, 2024

@sbordet This should now be fixed. I tested it in a small sample app using reactive client 1.x and 2.x. It would be great if you try a 5.3.33 snapshot to confirm.

@sbordet
Copy link

sbordet commented Feb 29, 2024

@poutsma I could confirm that this issue is now fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression
Projects
None yet
Milestone
5.3.33
Development

No branches or pull requests
2 participants
@poutsma @sbordet