Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better protect against concurrent error handling for async requests #32341

Closed
github-actions bot opened this issue Feb 28, 2024 · 1 comment
Closed

Better protect against concurrent error handling for async requests #32341

github-actions bot opened this issue Feb 28, 2024 · 1 comment
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
6.0.18

Comments

@github-actions
Copy link

Backport of gh-32340
@github-actions github-actions bot added in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug labels Feb 28, 2024
@github-actions github-actions bot added this to the 6.0.18 milestone Feb 28, 2024
@rstoyanchev rstoyanchev self-assigned this Feb 28, 2024
rstoyanchev added a commit that referenced this issue Feb 29, 2024
@rstoyanchev
Align 5.3.x with 6.1.x
814c003 
In preparation for a larger update, start by aligning with
6.1.x, which includes changes for gh-32042 and gh-30232.

See gh-32341
rstoyanchev added a commit that referenced this issue Mar 3, 2024
@rstoyanchev
Add state and response wrapping to StandardServletAsyncWebRequest
b208c63 
The wrapped response prevents use after AsyncListener onError or completion
to ensure compliance with Servlet Spec 2.3.3.4.

The wrapped response is applied in RequestMappingHandlerAdapter.

The wrapped response raises AsyncRequestNotUsableException that is now
handled in DefaultHandlerExceptionResolver.

See gh-32341
rstoyanchev added a commit that referenced this issue Mar 3, 2024
@rstoyanchev
Improve concurrent handling of result in WebAsyncManager
1a5661d 
1. Use state transitions
2. Increase synchronized scope in setConcurrentResultAndDispatch

See gh-32341
rstoyanchev added a commit that referenced this issue Mar 5, 2024
@rstoyanchev
Backport tests for wrapping of response for async requests
1a7a6f4 
This is a backport of commits 4b96cd and ef0717.

Closes gh-32341
@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Mar 5, 2024

Fixed via 1a7a6f4

@github-actions github-actions bot closed this as completed Mar 5, 2024
rstoyanchev added a commit that referenced this issue Mar 6, 2024
@rstoyanchev
DisconnectedClientHelper recognizes AsyncRequestNotUsableException
67ba7dd 
See gh-32341
rstoyanchev added a commit that referenced this issue Mar 7, 2024
@rstoyanchev
Use wrapped response in HandlerFunctionAdapter
36539bd 
webmvc.fn now also uses the StandardServletAsyncWebRequest wrapped response
to enforce lifecycle rules from Servlet spec (section 2.3.3.4).

See gh-32341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
6.0.18
Development

No branches or pull requests
1 participant
@rstoyanchev