Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine null-safety with NullAway build-time checks #32475

Closed
sdeleuze opened this issue Mar 18, 2024 · 0 comments
Closed

Refine null-safety with NullAway build-time checks #32475

sdeleuze opened this issue Mar 18, 2024 · 0 comments
Assignees
@sdeleuze @jhoeller
Labels
type: enhancement A general enhancement
Milestone
6.2.0-M1

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Mar 18, 2024 •
edited by sbrannen

As discussed with the JSpecify working group, the goal of this issue is to introduce null-safety checks at build-time using NullAway and the related Error Prone Gradle plugin and refine Spring null-safety annotations accordingly.

Unlike #28797, the purpose of this issue is to continue to leverage JSR 305 annotations. That said, such formal build-time checks will likely ease a potential transition to a different null-safety mechanism (JSpecify or at Java platform level) in the future.

See this draft commit that enables those null-checks on spring-core and generates 41 errors that will likely to lead null-safety refinements.
@sdeleuze sdeleuze added the type: enhancement A general enhancement label Mar 18, 2024
@sdeleuze sdeleuze added this to the 6.2.0-M1 milestone Mar 18, 2024
@sdeleuze sdeleuze self-assigned this Mar 18, 2024
jhoeller added a commit that referenced this issue Mar 18, 2024
@jhoeller
Nullability refinements
2f2c418 
See gh-32475
jhoeller added a commit that referenced this issue Mar 18, 2024
@jhoeller
Nullability refinements
5dc6a16 
See gh-32475
jhoeller added a commit that referenced this issue Mar 19, 2024
@jhoeller
Nullability refinements and related polishing
c531a8a 
See gh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 19, 2024
@sdeleuze
Nullability refinements
aa0fb97 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 19, 2024
@sdeleuze
Refine null-safety with NullAway build-time checks
4c77350 
This commit introduces null-safety checks for spring-core at build-time
in order to validate the consistency of Spring null-safety annotations
and generate errors when inconsistencies are detected during a build
(similar to what is done with Checkstyle).

In order to make that possible, this commit also introduces a new
org.springframework.lang.Contract annotation inspired from
org.jetbrains.annotations.Contract, which allows to specify semantics
of methods like Assert#notNull in order to prevent artificial
additional null checks in Spring Framework code base.

This commit only checks org.springframework.core package, follow-up
commits will also extend the analysis to other modules, after related
null-safety refinements.

See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 20, 2024
@sdeleuze
Refine null-safety in spring-expression
aa89d38 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 20, 2024
@sdeleuze
Perform NullAway build-time checks in spring-expression
7797866 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 20, 2024
@sdeleuze
Perform NullAway build-time checks in spring-expression
f648fd7 
See spring-projectsgh-32475
sdeleuze added a commit that referenced this issue Mar 20, 2024
@sdeleuze
Refine null-safety in spring-expression
2e98a8a 
See gh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 22, 2024
@sdeleuze
Refine null-safety in spring-webflux
87dfa49 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 22, 2024
@sdeleuze
Perform NullAway build-time checks in spring-webflux
0a50854 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 22, 2024
@sdeleuze
Refine null-safety in spring-webmvc
a16e8c3 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 22, 2024
@sdeleuze
Perform NullAway build-time checks in spring-webmvc
0e7aba4 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 25, 2024
@sdeleuze
Refine null-safety in spring-web and spring-websocket
a63ebe7 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 25, 2024
@sdeleuze
Perform NullAway build-time checks in spring-web
e52ee01 
Also in spring-websocket.

See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 25, 2024
@sdeleuze
Perform NullAway build-time checks in spring-jms
2fc78df 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 25, 2024
@sdeleuze
Refine null-safety in spring-jms
06b91c4 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 25, 2024
@sdeleuze
Refine null-safety in spring-messaging
dea31dd 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 25, 2024
@sdeleuze
Perform NullAway build-time checks in spring-messaging
7c009cc 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 26, 2024
@sdeleuze
Refine null-safety in more modules
1b563f8 
This commit refines the null-safety in:
 - spring-jdbc
 - spring-r2dbc
 - spring-orm
 - spring-beans
 - spring-aop

See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 26, 2024
@sdeleuze
Perform NullAway build-time checks in more modules
f68eee5 
This commit enables null-safety build-time checks in:
 - spring-jdbc
 - spring-r2dbc
 - spring-orm
 - spring-beans
 - spring-aop

See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 26, 2024
@sdeleuze
Perform NullAway build-time checks in more modules
5b660da 
This commit enables null-safety build-time checks in:
 - spring-jdbc
 - spring-r2dbc
 - spring-orm
 - spring-beans
 - spring-aop

See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 26, 2024
@sdeleuze
Refine null-safety in more modules
290a41d 
This commit refines the null-safety in all remaining modules
except spring-test.

See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 26, 2024
@sdeleuze
Perform NullAway build-time checks in more modules
8b51b36 
This commit enables null-safety build-time checks in
all remaining modules except spring-test.

See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Mar 26, 2024
@sdeleuze
Refine null-safety in spring-test
88b9c05 
See spring-projectsgh-32475
@sdeleuze sdeleuze mentioned this issue Mar 27, 2024
Closed
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Apr 5, 2024
@sdeleuze
Refine null-safety
2c69dc8 
See spring-projectsgh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Apr 5, 2024
@sdeleuze
Refine null-safety
e5ef9b9 
See spring-projectsgh-32475
sdeleuze added a commit that referenced this issue Apr 5, 2024
@sdeleuze
Refine null-safety
4a7c24d 
See gh-32475
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Apr 5, 2024
@sdeleuze
Revert some null-safety changes
7a666cf 
This commit reverts some null-safety changes which make sense
on main but are too impactful for 6.1.x for Kotlin developers
using -Xjsr305=strict.

See spring-projectsgh-32475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

@jhoeller jhoeller

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-M1
Development

No branches or pull requests
2 participants
@sdeleuze @jhoeller