Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce NoOp implementation for ResponseErrorHandler #32750

Closed
snicoll opened this issue May 2, 2024 · 0 comments
Closed

Introduce NoOp implementation for ResponseErrorHandler #32750

snicoll opened this issue May 2, 2024 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented May 2, 2024

There are cases where you'd like to not do anything special in case of error. Spring Boot already does that for its TestRestTemplate. ResponseErrorHandler makes it a tad harder as it has two handleError methods depending on the level of information available. This changed recently (#28958) which broke them.

Introducing a noop implementation that SB and others can use would be beneficial.

@snicoll snicoll added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels May 2, 2024
@snicoll snicoll added this to the 6.1.7 milestone May 2, 2024
@snicoll snicoll self-assigned this May 2, 2024
@snicoll snicoll changed the title Introduce NO_OP implementation for ResponseErrorHandler Introduce NoOp implementation for ResponseErrorHandler May 2, 2024
@snicoll snicoll closed this as completed in f90bdbe May 2, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 2, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 2, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 3, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 7, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 7, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 8, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 21, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 22, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 22, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue May 28, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue Jun 11, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue Jun 19, 2024
wilkinsona pushed a commit to spring-projects/spring-boot that referenced this issue Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant