Support for customization of 404 response when RouterFunctionWebHandler finds no routes #25358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terFunctionWebHandler
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
the
in: web
poutsma
changed the title
poutsma
added
type: enhancement
poutsma
pushed a commit
that referenced
this pull request
Dec 3, 2021
This commit makes it possible to customize 404 responses generated by RouterFunctionWebHandler, by throwing an ResponseStatusException instead of returning a standard 404 response. See gh-25358
poutsma
added a commit
that referenced
this pull request
Dec 3, 2021
poutsma
added a commit
that referenced
this pull request
Dec 3, 2021
…und-to-exception-pr * gh-25358: Polish "Throw 404 ResponseStatusException when no routes found" Throw 404 ResponseStatusException when no routes found
|
Merged in 2f557d9. Thank you for submitting a PR, and we are sorry it took this long to resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Next to the default WebServer a service starts another server to handle admin requests on a different port. The admin webserver is connected to the
HttpHandlercreated byRouterFunctions.toHttpHandler.When the admin server processes a request for a path not mapped to any
RouterFunctionthen the admin server responds with a 404 NotFound status code and an empty response body.Currently it is not possible to have a different response body.
Changing the
RouterFunctionWebHandlerto return aMono.error(new ResponseStatusException(HttpStatus.NOT_FOUND))instead ofServerResponse.notFound().build()allows clients to implement an exception handler that customizes the response body.Default behavior does not change because
WebFluxResponseStatusExceptionHandleris the default handler.