Improve performance of CompositePropertySource#getPropertyNames
#27236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shawyeok Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@Shawyeok Thank you for signing the Contributor License Agreement! |
Create LinkedHashSet with a initialCapacity, prevent underhood table resize cost in continuous add operations. Reduce bootstrap time in the situation with large properties.
Shawyeok
force-pushed
the
hotfix/improve-performance-of-get-property-names
branch
from
aefda4b
to
6f94f9f
Compare
rstoyanchev
added
the
in: core
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Aug 26, 2023
Create LinkedHashSet with a initialCapacity, prevent under the hood table resize cost in continuous add operations. Reduce bootstrap time in the case of large properties. See gh-27236
snicoll
added a commit
that referenced
this pull request
Aug 26, 2023
|
@Shawyeok thank you for making your first contribution to Spring Framework. |
It's great to see it get merged even two years later. |
sbrannen
changed the title
CompositePropertySource#getPropertyNames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create LinkedHashSet with a initialCapacity, prevent underhood table resize cost in continuous add operations.
Reduce bootstrap time in the situation with large properties.
Micro-Benchmark
CompositePropertySourceBenchmarkresult (unit: ns/op):numberOfPropertySource: 5
numberOfPropertyNamesPerSource: 1000
numberOfPropertySource: 10
numberOfPropertyNamesPerSource: 1000