Add ParameterNamesModule to "well known" jackson modules #27511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
the
in: web
sdeleuze
added
type: enhancement
sdeleuze
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
ParameterNamesModule looks useful for common use case, so I will merge those changes.
I will raise your point about enabling service loader instead with the team. Well-know modules can be enabled via this mechanism so if it does not introduce side effects, that could indeed be an alternative.
sdeleuze
pushed a commit
to sdeleuze/spring-framework
that referenced
this pull request
Aug 28, 2023
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this pull request
Aug 28, 2023
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this pull request
Aug 28, 2023
|
Notice such change was also discussed in #17886, and at that time we decided to not include it, but nowadays I expect developers to use much more constructor binding, so using this default makes sense. Inclusion in the Release Candidate will give us the opportunity to revise that choice if we have feedback mentioning unwanted side effects. |
sdeleuze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I'm surprised to see that
org.springframework.http.converter.json.Jackson2ObjectMapperBuilder#findModulesViaServiceLoaderis nottrueby default. Why not always just let it scan the classpath, seems likefindWellKnownModulesdoes the same but manually.