Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the basePackage do not have META-INF/spring.component then switc… #27674

Closed
wants to merge 1 commit into from

Conversation

qxo
Copy link
Contributor

@qxo qxo commented Nov 11, 2021

If the basePackage not defined in META-INF/spring.component,
then using old scanCandidateComponents(basePackage);

Otherwise the basePackage not in META-INF/spring.component will not load
if the env classpath has any META-INF/spring.component file.

the issue poc code: https://github.com/qxo/spring-components-index-bug-poc

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 11, 2021
…h scanCandidateComponents(basePackage)

If the basePackage not defined in META-INF/spring.component,
then using old `scanCandidateComponents(basePackage)`;

Otherwise the basePackage not in META-INF/spring.component will not load
if the env classpath has any META-INF/spring.component file.
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 12, 2021
@snicoll
Copy link
Member

snicoll commented Aug 26, 2023

@qxo thanks for the PR but the component indexer has been deprecated so we won't make further change to it, see #30431

@snicoll snicoll closed this Aug 26, 2023
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants