Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in BeanPropertyRowMapper regarding underscore name #27941

Closed
wants to merge 1 commit into from

Conversation

mdeinum
Copy link
Contributor

@mdeinum mdeinum commented Jan 17, 2022

With 6316a35 I introduced a regression for properties starting with an uppercase letter.

This commit fixes that regression including an additional test to cover this case.

Fixes: gh-27929

With 6316a35 I introduced a regression for fields starting
with an uppercase letter. This commit fixes that regression
including an additional test to cover this case.

Fixes: spring-projectsgh-27929
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 17, 2022
@sbrannen sbrannen self-assigned this Jan 17, 2022
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 17, 2022
@sbrannen sbrannen added this to the 5.3.16 milestone Jan 17, 2022
@sbrannen sbrannen changed the title Fix regression with underscore name Fix regression in BeanPropertyRowMapper regarding underscore name Jan 17, 2022
@sbrannen sbrannen closed this in 261bc2a Jan 17, 2022
@sbrannen
Copy link
Member

This has been merged into 5.3.x and main.

Thanks for fixing your own regression! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: regression A bug that is also a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BeanPropertyRowMapper underscoreName prepends redundant underscore when field descriptor begins in uppercase
3 participants