Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "*" catch-all mappings for MockMvc Filter registrations #28041

Closed
wants to merge 2 commits into from

Conversation

funky-eyes
Copy link
Contributor

I believe most business developers think * is equivalent to /*

fixes #28017

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 11, 2022
@bclozel
Copy link
Member

bclozel commented Feb 11, 2022

The intent behind #28017 so far is documentation only. This PR changes the behavior and we didn't come to that conclusion yet. Would you like to amend this PR address the original issue?

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Feb 11, 2022
@funky-eyes
Copy link
Contributor Author

funky-eyes commented Feb 11, 2022

Could you please tell me exactly how to do that? @bclozel

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 11, 2022
@funky-eyes
Copy link
Contributor Author

The intent behind #28017 so far is documentation only. This PR changes the behavior and we didn't come to that conclusion yet. Would you like to amend this PR address the original issue?

I think the #28017 solution is more than just documentation, it should be supported at the code level

@bclozel bclozel added for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on status: feedback-provided Feedback has been provided labels Feb 12, 2022
@bclozel bclozel added this to the 6.x Backlog milestone Feb 12, 2022
@bclozel bclozel added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Feb 12, 2022
@funky-eyes
Copy link
Contributor Author

@bclozel When can you review the PR, please?

@sbrannen sbrannen changed the title Support * is equivalent to /* Support * equivalent to /* in PatternMappingFilterProxy Jan 24, 2023
@bclozel bclozel self-assigned this Jan 25, 2023
@bclozel bclozel modified the milestones: 6.x Backlog, 6.1.x Jan 31, 2023
@bclozel bclozel changed the title Support * equivalent to /* in PatternMappingFilterProxy Support "*" catch-all mappings for MockMvc Filter registrations Oct 20, 2023
@pivotal-cla
Copy link

@funky-eyes Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@bclozel bclozel added in: test Issues in the test module and removed for: merge-with-amendments Needs some changes when we merge labels Oct 20, 2023
@bclozel bclozel modified the milestones: 6.1.x, 6.1.0-RC2 Oct 20, 2023
@bclozel bclozel closed this in 4bf995f Oct 20, 2023
bclozel added a commit that referenced this pull request Oct 20, 2023
@bclozel
Copy link
Member

bclozel commented Oct 20, 2023

Thanks @funky-eyes for your contribution, this is now merged.

@pivotal-cla
Copy link

@funky-eyes Thank you for signing the Contributor License Agreement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PatternMappingFilterProxy#addUrlPattern not support * url pattern
4 participants