Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate support for theme #29114

Closed
wants to merge 1 commit into from
Closed

Deprecate support for theme #29114

wants to merge 1 commit into from

Conversation

Nheyll
Copy link
Contributor

@Nheyll Nheyll commented Sep 9, 2022

This PR resolves the following issue #28868
I tried to apply the practices used in prior deprecation (ex : PropertyPlaceholderConfigurer, FailureCallback) which are :

  • Deprecate all classes fully related to theming
  • Update javadoc with @deprecated as of 6.0, with no direct replacement
  • Remove imports in other classes
  • Deprecate methods and classes related to theming in other classes
  • Update javadoc in other classes with Theme support is deprecated as of 6.0
  • Suppress the deprecation warnings in test classes

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 9, 2022
@bclozel bclozel self-assigned this Sep 9, 2022
@bclozel bclozel mentioned this pull request Sep 9, 2022
Closed
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 9, 2022
@bclozel bclozel added this to the 6.0.0-M6 milestone Sep 9, 2022
@bclozel bclozel closed this in 0581093 Sep 9, 2022
bclozel added a commit that referenced this pull request Sep 9, 2022
@bclozel
Polish
c72c2ff 
See gh-29114
@bclozel
Copy link
Member

bclozel commented Sep 9, 2022

Thanks @Nheyll , this will be in the next milestone!

izeye added a commit to izeye/spring-framework that referenced this pull request Sep 25, 2022
@izeye
Polish "Deprecate support for theme" changes
a2a9aa3 
See spring-projectsgh-29114
@izeye izeye mentioned this pull request Sep 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nheyll @bclozel @spring-projects-issues