Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebClient and WebFlux Observation do not propagate context #29388

Conversation

marcingrzejszczak
Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Oct 26, 2022

currently it's impossible to mutate the headers since we're using their immutable versions.

also WebFlux filter is not propagating the built observation as an entry in the reactor context.

fixes #29339

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 26, 2022
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug theme: observability An issue related to observability and tracing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 2, 2022
@bclozel bclozel added this to the 6.0.0-RC3 milestone Nov 2, 2022
@bclozel bclozel changed the title Fixed WebFlux and WebClient instrumentation WebClient Observation does not propagate context Nov 2, 2022
@bclozel bclozel changed the title WebClient Observation does not propagate context WebClient and WebFlux Observation do not propagate context Nov 2, 2022
@bclozel bclozel self-assigned this Nov 2, 2022
@bclozel bclozel closed this in c03ccb2 Nov 2, 2022
bclozel added a commit that referenced this pull request Nov 2, 2022
bclozel added a commit to spring-projects/spring-boot that referenced this pull request Nov 2, 2022
@marcingrzejszczak marcingrzejszczak deleted the webFluxObservations branch November 3, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebClient Observation does not propagate context
3 participants