Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong asserted code in SQLExceptionSubclassTranslatorTests #29748

Merged
merged 1 commit into from Jan 3, 2023
Merged

Fix wrong asserted code in SQLExceptionSubclassTranslatorTests #29748

merged 1 commit into from Jan 3, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Dec 28, 2022

It seems to be a copy-and-paste error.

See a644245

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 28, 2022
simonbasle
simonbasle approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed looks like a typo. the test was still green due to the blanket acceptability of any 23505 combination

@simonbasle simonbasle added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 3, 2023
@simonbasle simonbasle added this to the 6.0.4 milestone Jan 3, 2023
@simonbasle simonbasle changed the title Fix copy-and-paste error in exceptionClassTranslation() Fix wrong asserted code in SQLExceptionSubclassTranslatorTests Jan 3, 2023
@simonbasle simonbasle merged commit 62cf2f0 into spring-projects:main Jan 3, 2023
@izeye izeye deleted the fix-copy-and-paste-error branch January 3, 2023 13:08
@izeye
Copy link
Contributor Author

izeye commented Jan 3, 2023

This is not a user-facing enhancement, so the "type: task" label seems to be better for this.

@simonbasle simonbasle added type: task A general task and removed type: enhancement A general enhancement labels Jan 3, 2023
mdeinum pushed a commit to mdeinum/spring-framework that referenced this pull request Jun 29, 2023
@izeye @mdeinum
Fix wrong asserted code in SQLExceptionSubclassTranslatorTests (sprin…
f42ec1b 
…g-projects#29748)

There was a typo in the test, covering the wrong SQLState code.

Polishes a644245.
Relates to spring-projectsgh-29699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle simonbasle approved these changes

Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
6.0.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@izeye @simonbasle @spring-projects-issues